Conversation
tvdeyen
force-pushed
the
allow-element-icon
branch
3 times, most recently
from
c46d8e0 to
915d87e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3356 +/- ##
=======================================
Coverage 97.13% 97.14%
=======================================
Files 277 277
Lines 7217 7242 +25
=======================================
+ Hits 7010 7035 +25
Misses 207 207 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Useful if you want to distingiush elements visually.
Adds a new alchemy-element-select web-component
In order to visually indicate the user that the element can be dragged, we show the former draggable element icon on titlebar hover.
Remove the `element_for_select` helper and put the logic into a testable view component.
tvdeyen
force-pushed
the
allow-element-icon
branch
from
915d87e to
d14883e
Compare
sascha-karnatz
approved these changes
Sep 4, 2025
| @@ -0,0 +1,43 @@ | |||
| import { hightlightTerm } from "alchemy_admin/components/remote_select" | |||
|
|
|||
| const formatItem = (icon, text) => { | |||
Contributor
There was a problem hiding this comment.
Can we integrate that function as a private method in the ElementSelect?
#formatItem(....) {
....
}
Member
Author
There was a problem hiding this comment.
It is privat, because it is only locally available and not exported. So, where is the difference?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Extracted from #3262
Allows to set an icon on the element definition by setting it to an
svgicon* name.or you can set
icontotrue. It will take the elementnameas icon name in this case.Note
*) Icons need to be SVGs (because we inline them so the color can be changed in light/dark modes and on element title hover) and be placed in
app/assets/images/alchemy/element_icons.Notable changes
Removes the
Alchemy::Admin::ElementsHelperChanges the default element icon from
to 
, but keeps the "draggable" icon on hover
CleanShot.2025-09-02.at.11.02.21.mp4
Screenshots
Checklist