Add session management during shutdown and improve session handling#915
Merged
bboynton97 merged 2 commits intomainfrom Apr 11, 2025
Merged
Add session management during shutdown and improve session handling#915bboynton97 merged 2 commits intomainfrom
bboynton97 merged 2 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Contributor
|
double print is actually expected. one at kickoff and the other at the end of the run. API key was an issue with local environment. nice job @Dwij1704 :) |
bboynton97
reviewed
Apr 9, 2025
bboynton97
reviewed
Apr 9, 2025
bboynton97
approved these changes
Apr 9, 2025
Contributor
bboynton97
left a comment
There was a problem hiding this comment.
this definitively limits us to one trace at a time. meaning we cannot track multiple agents running at once with the same agentops client.
this may need to be refactored for that in the future if/when that functionality is required
Contributor
|
verified it works with manual testing connected to prod |
Contributor
|
Is this ready to merge @Dwij1704 ? |
Member
Author
Yes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📥 Pull Request
📘 Description
Closes #914
Add session management during shutdown and improve session handling