Skip to content

Comments

OpenAI Agents voice support#900

Merged
dot-agi merged 27 commits intomainfrom
agents-voice
Apr 2, 2025
Merged

OpenAI Agents voice support#900
dot-agi merged 27 commits intomainfrom
agents-voice

Conversation

@tcdent
Copy link
Contributor

@tcdent tcdent commented Mar 28, 2025 •
edited
Loading

  • Captures span data for transcriptions & speech.
  • Uploads audio data to AgentOps backend.

Example agent script at: examples/agents-example/voice_transcription.py

tcdent added 21 commits March 25, 2025 13:08
@tcdent
Update attribute extraction to support dict as well as object.
953305e
@tcdent
Adjust tests to match serialization format of list[str]. Patch JSON…
ab8dad1 
… encode in tests to handle MagicMock objects.
@tcdent
Instrumentor and wrappers for OpenAI responses.
fd4b4f8
@tcdent
Collect base usage attributes, too.
4c6b12f
@tcdent
Merge branch 'main' into fix-openai-agents-counts
0ebd74d
@tcdent
Move Response attribute parsing to openai module. Move common attribu…
5589ec6 
…te parsing to common module.
@tcdent
Include tags in parent span. Helpers for accessing global config and …
f2dca86 
…tags. Tests for helpers and common insrumentation attributes.
@tcdent
Add tags to an example.
e1e3506
@tcdent
Remove duplicate library attributes.
d7a9f6f
@tcdent
Pass OpenAI responses objects through our new instrumentor.
f30f43a
@tcdent
Merge branch 'fix-openai-agents-counts' into openai-responses
d98a5b0
@tcdent
Incorporate common attributes, too.
e942f94
@tcdent
Add indexed PROMPT semconv to MessageAttributes. Provide reusable wra…
9b2c5f7 
…pping functionality from instrumentation.common. Include prompts in OpenAI Responses attributes.
@tcdent
Type checking.
d58af58
@tcdent
Test coverage for instrumentation.common
9d2d493
@tcdent
Type in method def should be string in case of missing import.
12b559b
@tcdent
Wrap third party module imports from openai in try except block
9d77845
@tcdent
OpenAI instrumentation tests. (Relocated to openai_core to avoid impo…
d5cdb57 
…rt hijack)
@tcdent
Merge branch 'main' into openai-responses
0df12c2
@tcdent
Merge branch 'openai-responses' into agents-voice
c430ad9
@tcdent
OpenAI Agents voice support
fe8932c
@tcdent tcdent requested a review from dot-agi March 28, 2025 02:06
@codecov
Copy link

codecov bot commented Mar 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.98089% with 66 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...instrumentation/openai_agents/attributes/common.py 50.74% 33 Missing ⚠️
agentops/client/api/versions/v4.py 32.25% 21 Missing ⚠️
agentops/instrumentation/openai/instrumentor.py 86.20% 4 Missing ⚠️
agentops/instrumentation/openai/__init__.py 75.00% 3 Missing ⚠️
agentops/instrumentation/common/objects.py 66.66% 2 Missing ⚠️
...entops/instrumentation/openai/attributes/common.py 91.30% 2 Missing ⚠️
agentops/instrumentation/common/attributes.py 97.56% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@tcdent tcdent linked an issue Mar 28, 2025 that may be closed by this pull request
OpenAI Agents voice support #884
Closed
teocns
teocns suggested changes Mar 28, 2025
View reviewed changes
teocns
teocns previously requested changes Mar 28, 2025
View reviewed changes
dot-agi
dot-agi requested changes Apr 1, 2025
View reviewed changes
Copy link
Member

@dot-agi dot-agi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for improving code quality.

I was not able to test this PR with the voice_transcription.py file due to receiving the ApiServerException exception.

Is there a way to test this in realtime? I have two more notebooks to test from the OpenAI Cookbook website.

@tcdent
Copy link
Contributor Author

tcdent commented Apr 1, 2025

Left some comments for improving code quality.

I was not able to test this PR with the voice_transcription.py file due to receiving the ApiServerException exception.

Is there a way to test this in realtime? I have two more notebooks to test from the OpenAI Cookbook website.

You need to run the backend API from #817.

AGENTOPS_API_ENDPOINT="http://localhost:8000"; uv run examples/agents-example/voice_transcription.py

@dot-agi dot-agi self-requested a review April 2, 2025 12:17
dot-agi
dot-agi approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@dot-agi dot-agi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

challenged

@dot-agi dot-agi enabled auto-merge (squash) April 2, 2025 18:39
@dot-agi dot-agi requested a review from teocns April 2, 2025 18:48
@dot-agi dot-agi dismissed teocns’s stale review April 2, 2025 18:51

Changes were made in the deleted file.

@dot-agi dot-agi merged commit f111f55 into main Apr 2, 2025
8 of 10 checks passed
@dot-agi dot-agi deleted the agents-voice branch April 2, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dot-agi dot-agi dot-agi approved these changes

@teocns teocns Awaiting requested review from teocns

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OpenAI Agents voice support

3 participants

@tcdent @teocns @dot-agi