Fix: Improve serialization of completions/responses in Agents SDK instrumentation#844
Closed
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Closed
Fix: Improve serialization of completions/responses in Agents SDK instrumentation#844devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
…trumentation Co-Authored-By: travis@agentops.ai <travis@agentops.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: travis@agentops.ai <travis@agentops.ai>
Contributor
Author
|
Closing in favor of PR #845 which contains only the essential serialization fix changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Improve serialization of completions/responses in Agents SDK instrumentation
This PR fixes the serialization of completions/responses in the Agents SDK OpenTelemetry instrumentation. Instead of truncating or printing the string representation of the object, it now extracts specific fields referenced in the semconv definitions.
Changes
model_as_dict()helper function to safely convert response objects to dictionaries_export_span()method to extract specific fields from response objects:Benefits
Link to Devin run: https://app.devin.ai/sessions/480cc142d3b94f70828c01815f3622ef
This is a draft PR for exploring potential solutions to the problem.