Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
teocns
force-pushed
the
teocns/improve-session-tests-assertions
branch
from
d5b94d4 to
10930f0
Compare
areibman
approved these changes
Feb 6, 2025
Contributor
areibman
left a comment
areibman
left a comment
There was a problem hiding this comment.
Broken test but not your fault, approving
…` checks with specific request filtering 1. Replaced `assert len(mock_req.request_history) == N` checks with specific request filtering 2. Added helper to find relevant requests using URL patterns 3. Made assertions more focused on the actual tool recording functionality 4. Maintained all existing functionality checks while removing dependency on request count
… N` checks with specific request filtering Replaced request count assertions with specific request filtering Added helper to find relevant requests using URL patterns Made assertions more focused on the actual action recording functionality Maintained all existing functionality checks while removing dependency on request count Signed-off-by: Teo <teocns@gmail.com>
…ecks with specific request filtering Signed-off-by: Teo <teocns@gmail.com>
…hecks with specific request filtering Signed-off-by: Teo <teocns@gmail.com>
…cks with specific request filtering Signed-off-by: Teo <teocns@gmail.com>
teocns
force-pushed
the
teocns/improve-session-tests-assertions
branch
from
10930f0 to
94e077a
Compare
teocns
added a commit
that referenced
this pull request
Feb 6, 2025
…uests) Signed-off-by: Teo <teocns@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests are failing due to an inefficiency in the test criteria. Testing for len() of requests makes it fail - every time we change the number of requests fired by the SDK, we would have to change these tests.
assert len(mock_req.request_history) == Nchecks with specific request filtering