Merged
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
bboynton97
reviewed
Jun 4, 2025
tcdent
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
📘 Description
Closes #1021
Introduced
extract_agent_attributesfunction to gather detailed attributes from agent instances, including name, description, model, instruction, tools, and sub-agents.Enhanced tool attribute setting to include tool description and long-running status, further enriching telemetry data.
Added a helper function
_is_actually_installed_packageto verify if a module is an installed package or a local module, improving accuracy in instrumentation decisions.Refined the
_is_package_instrumentedfunction to utilize a more precise check based on registered keys.Updated the
_uninstrument_providersfunction to better manage active instrumentors, ensuring only relevant ones remain active.Enhanced the
_should_instrument_packagefunction to incorporate checks for agentic libraries and providers, improving the decision-making process for instrumentation.Improved logging throughout the instrumentation process for better traceability and debugging.
Added checks in
_perform_instrumentationto ensure proper handling of package names and configurations, enhancing overall robustness.🧪 Testing
Tested OG crew and a few more indirect import examples
EXAMPLE TO TEST ADK