feat: react 19 support and new onShow and onHide triggers#1
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds React 19-related updates and introduces new Menu visibility callbacks (onShow/onHide) while deprecating onVisibilityChange.
Changes:
- Updated React type dependencies (and related lockfile entries) toward React 19.
- Added
onShow(fromHidden)andonHide()toMenu, and markedonVisibilityChangeas deprecated. - Updated build config to externalize React runtime packages.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updates resolved dependency graph for React 19 types and related packages. |
| tsup.config.ts | Marks react, react-dom, and react/jsx-runtime as externals for bundling. |
| src/components/Menu.tsx | Adds onShow/onHide, deprecates onVisibilityChange, and adds ref plumbing. |
| src/components/Item.tsx | Initializes useRef with null (typing/runtime alignment). |
| package.json | Updates peer/dev dependency declarations to React 19 types and adjusts React peer range. |
Comments suppressed due to low confidence (1)
package.json:79
- Removing
react/react-domfrom rootdevDependencieswill break the repo’s example app and CI:example/package.jsonaliasesreactandreact-domto../node_modules/*, and the GitHub Action starts the example viayarn start. Re-addreact/react-domas devDependencies (or move them intoexampledependencies and update the alias strategy/CI accordingly).
"devDependencies": {
"@types/react": "^19.2.7",
"@types/react-dom": "^19.2.3",
"cssnano": "^5.1.14",
"cssnano-cli": "^1.0.5",
"cypress": "^11.0.1",
"postcss": "^8.4.18",
"postcss-cli": "^10.0.0",
"sass": "^1.56.1",
"style2js": "^1.0.1",
"tsup": "^6.4.0",
"typescript": "^4.8.4"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bilb
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back-ported PRs and Issues from origin:
onShownandonHiddencontinue appearing in the doc after been removed fkhadra/react-contexify#252