Translate dyn Trait method shims
#814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssyram
force-pushed
the
dyn-trait-instance
branch
from
0823773 to
4d86339
Compare
Nadrieril
reviewed
Sep 16, 2025
Nadrieril
reviewed
Sep 16, 2025
Nadrieril
reviewed
Sep 16, 2025
Nadrieril
reviewed
Sep 16, 2025
charon/src/bin/charon-driver/translate/translate_trait_objects.rs
Outdated
Show resolved
Hide resolved
Nadrieril
reviewed
Sep 16, 2025
charon/src/bin/charon-driver/translate/translate_trait_objects.rs
Outdated
Show resolved
Hide resolved
Nadrieril
reviewed
Sep 16, 2025
charon/src/bin/charon-driver/translate/translate_trait_objects.rs
Outdated
Show resolved
Hide resolved
Nadrieril
reviewed
Sep 16, 2025
Nadrieril
reviewed
Sep 16, 2025
Member
Nadrieril
left a comment
Nadrieril
left a comment
There was a problem hiding this comment.
Overall looks pretty good, ty! Marking it as draft while you address the comments.
ssyram
force-pushed
the
dyn-trait-instance
branch
from
c4493e1 to
ee928ae
Compare
Contributor
Author
|
Fixed the |
Member
|
I renamed |
Contributor
Author
|
OK, I will try to implement it. |
Contributor
Author
|
OK, updated. |
ssyram
force-pushed
the
dyn-trait-instance
branch
from
a5662db to
cda7046
Compare
Member
|
Sorry I just created merge conflicts for you again |
Co-authored-by: ssyram <liguany126@126.com>
Co-authored-by: ssyram <liguany126@126.com>
Co-authored-by: ssyram <liguany126@126.com>
Nadrieril
force-pushed
the
dyn-trait-instance
branch
2 times, most recently
from
06a7b80 to
e84b41e
Compare
Co-authored-by: ssyram <liguany126@126.com>
Nadrieril
force-pushed
the
dyn-trait-instance
branch
from
e84b41e to
b51c1fc
Compare
This was referenced Oct 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is split from #762 . It contains the part of the implementation for supporting vtable instances. For each concrete casting from
&Tto&dyn Trait, a globalstatic {impl Trait for T}::{vtable}will be generated, which initialises the method fields with the method shims --- notably, when one calls amethodfrom&dyn Trait, the receiver is&dyn Traitinstead of the concrete type&T. This requires a bridging method that uses aConcretizecast to cast back from&dyn Traitto&Tand then call the correctmethodwithin the user-definedimpl Trait for T.Note that this PR does not handle the virtual implementations, e.g., closures --- there is no explicit
impl Fn for CLOSUREthat is defined by the user. This will be fixed in the up-coming PR split from #762 .Also, in this PR, the metadata fields of the vtable instances, i.e., the
size,alignanddropfields are not translated and are currentlyOpaque. This will also be partly alleviated in the up-coming PR from #762 .ci: use AeneasVerif/aeneas#619
ci: use AeneasVerif/eurydice#294