[payout] Code generation: update services and models#1950
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a metadata log for the 'payout' service and includes minor code cleanup and reformatting within the 'clouddevice' service. A review comment highlights a discrepancy between the service name specified in the new metadata file and the actual code changes provided, suggesting a potential issue with the automated generation or missing files.
e759a3f to
8e75c50
Compare
9ae5eb8 to
0f4b73c
Compare
16cf6b4 to
4ff79ab
Compare
4ff79ab to
89ef1ac
Compare
jeandersonbc
approved these changes
May 15, 2026
Contributor
jeandersonbc
left a comment
There was a problem hiding this comment.
[payout] Add cardAltID, networkProcessingMode fields and relax cardProductId to open String
Summary
Two payout response model classes are updated to reflect changes in the Adyen OpenAPI spec:
ResponseAdditionalDataCardgains a newcardAltIDfield and drops theCardProductIdEnuminner enum in favour of a plainStringforcardProductId.ResponseAdditionalDataCommongains a newnetworkProcessingModefield.
⚠️ Breaking change:cardProductIdgetter/setter/builder signatures change fromCardProductIdEnumtoString. Any caller referencingCardProductIdEnumor its constants
will fail to compile.
Features Added
| Field | Class | Description |
|---|---|---|
cardAltID |
ResponseAdditionalDataCard |
ALT ID (alternate ID) mapped to the Card PAN. Returned only for Ecommerce Card Payments in India. |
networkProcessingMode |
ResponseAdditionalDataCommon |
Indicates the processing flow: sale (auto-capture) or auth (manual capture required). |
Features Removed
| Removed | Class | Details |
|---|---|---|
CardProductIdEnum inner enum |
ResponseAdditionalDataCard |
Fully removed, including its @JsonCreator/@JsonValue logic and unknown-value warning. Unused imports |
(JsonCreator, JsonValue, Arrays, Logger) are also cleaned up. |
Behavioral Changes
| Change | Class | Details |
|---|---|---|
cardProductId type: CardProductIdEnum → String |
ResponseAdditionalDataCard |
All getter, setter, and builder overloads now accept/return String. Enables forward-compatibility with card product IDs not previously enumerated by the enum. Breaking for existing callers. |
equals / hashCode / toString updated |
ResponseAdditionalDataCard, ResponseAdditionalDataCommon |
New fields (cardAltID, networkProcessingMode) are included in equality checks, hash computation, and string serialization. |
| Null-serialization guard added for new fields | ResponseAdditionalDataCard, ResponseAdditionalDataCommon |
The addIfNull / isSet* pattern is applied to both new fields, consistent with existing field handling. |
Doc Changes
| Change | Class | Details |
|---|---|---|
| "Possible values" → "Example values" | ResponseAdditionalDataCard |
All Javadoc for cardProductId (getter, setter, builder) updated to reflect that the listed Visa/Mastercard codes are examples, not an exhaustive set — consistent with the type relaxation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the automated changes for the
payoutservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.