[payout] Code generation: update services and models#1731
[payout] Code generation: update services and models#1731AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers an automated update to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR updates the payout service models, seemingly from a code generator. The main change is in FraudResultTypeEnum, where FRAUD is replaced by RED and AMBER is added. While this seems like a valid API update, replacing an enum constant is a breaking change. I've added a comment with a suggestion to maintain backward compatibility by deprecating the old constant instead of removing it. The other changes are Javadoc updates reflecting the enum changes, which look fine.
| public enum FraudResultTypeEnum { | ||
| AMBER(String.valueOf("AMBER")), | ||
|
|
||
| GREEN(String.valueOf("GREEN")), | ||
|
|
||
| FRAUD(String.valueOf("FRAUD")); | ||
| RED(String.valueOf("RED")); |
There was a problem hiding this comment.
Replacing FRAUD with RED is a breaking change. This will cause compilation errors for clients using FraudResultTypeEnum.FRAUD and can lead to runtime errors if the API still sends "FRAUD" as a value (which would result in null from fromValue).
To maintain backward compatibility, consider re-adding FRAUD as a deprecated constant. This allows existing client code to compile and run, while encouraging migration to RED. You may also want to update the Javadoc for the enum to mention the deprecation.
| public enum FraudResultTypeEnum { | |
| AMBER(String.valueOf("AMBER")), | |
| GREEN(String.valueOf("GREEN")), | |
| FRAUD(String.valueOf("FRAUD")); | |
| RED(String.valueOf("RED")); | |
| public enum FraudResultTypeEnum { | |
| AMBER(String.valueOf("AMBER")), | |
| GREEN(String.valueOf("GREEN")), | |
| RED(String.valueOf("RED")), | |
| /** @deprecated Replaced by {@link #RED}. */ | |
| @Deprecated | |
| FRAUD(String.valueOf("FRAUD")); |
This PR contains the automated changes for the
payoutservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.