Skip to content

[balanceplatform] Code generation: update services and models#1729

Open
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/balanceplatform
Open

[balanceplatform] Code generation: update services and models#1729
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/balanceplatform

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the balanceplatform service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested a review from a team as a code owner February 17, 2026 21:47
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch from 6d90228 to fd84c0f Compare February 17, 2026 21:47
@AdyenAutomationBot AdyenAutomationBot requested a review from a team as a code owner February 17, 2026 21:47
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the balanceplatform service by introducing new data models and API functionality related to tax form summaries. The changes enable the retrieval of a summary of tax forms for an account holder, detailing the legal entity ID and the relevant tax years. This enhancement provides more granular access to tax-related information within the platform.

Highlights

  • New Models Added: Introduced Summary.java and TaxFormSummaryResponse.java models to represent tax form summaries for legal entities.
  • New API Endpoint: Added getTaxFormSummary methods to the AccountHoldersApi for retrieving tax form summaries for a given account holder.
  • Documentation Updates: Updated Javadoc for existing getTaxForm methods in AccountHoldersApi for improved clarity on parameter descriptions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/main/java/com/adyen/model/balanceplatform/Summary.java
    • Added a new model to represent a summary of tax forms for a legal entity, including legalEntityId and taxYears.
  • src/main/java/com/adyen/model/balanceplatform/TaxFormSummaryResponse.java
    • Added a new model to encapsulate a list of Summary objects, providing a response structure for tax form summaries.
  • src/main/java/com/adyen/service/balanceplatform/AccountHoldersApi.java
    • Imported the newly added TaxFormSummaryResponse model.
    • Added two new public methods, getTaxFormSummary(String id, String formType) and getTaxFormSummary(String id, String formType, RequestOptions requestOptions), to fetch tax form summaries.
    • Updated the Javadoc for the getTaxForm methods to refine the descriptions for formType, year, and legalEntityId parameters.
Activity
  • The pull request contains automated changes for the balanceplatform service.
  • The commit history reflects applied adyen-openapi commits, indicating code generation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces automated changes for the balanceplatform service, adding new models Summary and TaxFormSummaryResponse, and a new endpoint to get tax form summaries. The changes are mostly auto-generated. I've identified an area for improvement in the new getTaxFormSummary method in AccountHoldersApi.java where a required parameter is not being validated, which is inconsistent with how other required parameters are handled.

Comment on lines +303 to +325
public TaxFormSummaryResponse getTaxFormSummary(
String id, String formType, RequestOptions requestOptions) throws ApiException, IOException {
// Add path params
Map<String, String> pathParams = new HashMap<>();
if (id == null) {
throw new IllegalArgumentException("Please provide the id path parameter");
}
pathParams.put("id", id);

// Add query params
Map<String, String> queryParams = new HashMap<>();
if (formType != null) {
queryParams.put("formType", formType);
}

String requestBody = null;
Resource resource =
new Resource(this, this.baseURL + "/accountHolders/{id}/taxFormSummary", null);
String jsonResult =
resource.request(
requestBody, requestOptions, ApiConstants.HttpMethod.GET, pathParams, queryParams);
return TaxFormSummaryResponse.fromJson(jsonResult);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Javadoc for this method indicates that the formType parameter is required. However, there is no validation to ensure it's not null. This is inconsistent with how the required path parameter id is handled. To improve robustness and provide clearer error messages to developers, you should add a null check for formType.

  public TaxFormSummaryResponse getTaxFormSummary(
      String id, String formType, RequestOptions requestOptions) throws ApiException, IOException {
    // Add path params
    Map<String, String> pathParams = new HashMap<>();
    if (id == null) {
      throw new IllegalArgumentException("Please provide the id path parameter");
    }
    pathParams.put("id", id);

    if (formType == null) {
      throw new IllegalArgumentException("Please provide the formType query parameter");
    }

    // Add query params
    Map<String, String> queryParams = new HashMap<>();
    queryParams.put("formType", formType);

    String requestBody = null;
    Resource resource =
        new Resource(this, this.baseURL + "/accountHolders/{id}/taxFormSummary", null);
    String jsonResult =
        resource.request(
            requestBody, requestOptions, ApiConstants.HttpMethod.GET, pathParams, queryParams);
    return TaxFormSummaryResponse.fromJson(jsonResult);
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant