[balanceplatform] Code generation: update services and models#1729
[balanceplatform] Code generation: update services and models#1729AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
6d90228 to
fd84c0f
Compare
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces automated changes for the balanceplatform service, adding new models Summary and TaxFormSummaryResponse, and a new endpoint to get tax form summaries. The changes are mostly auto-generated. I've identified an area for improvement in the new getTaxFormSummary method in AccountHoldersApi.java where a required parameter is not being validated, which is inconsistent with how other required parameters are handled.
| public TaxFormSummaryResponse getTaxFormSummary( | ||
| String id, String formType, RequestOptions requestOptions) throws ApiException, IOException { | ||
| // Add path params | ||
| Map<String, String> pathParams = new HashMap<>(); | ||
| if (id == null) { | ||
| throw new IllegalArgumentException("Please provide the id path parameter"); | ||
| } | ||
| pathParams.put("id", id); | ||
|
|
||
| // Add query params | ||
| Map<String, String> queryParams = new HashMap<>(); | ||
| if (formType != null) { | ||
| queryParams.put("formType", formType); | ||
| } | ||
|
|
||
| String requestBody = null; | ||
| Resource resource = | ||
| new Resource(this, this.baseURL + "/accountHolders/{id}/taxFormSummary", null); | ||
| String jsonResult = | ||
| resource.request( | ||
| requestBody, requestOptions, ApiConstants.HttpMethod.GET, pathParams, queryParams); | ||
| return TaxFormSummaryResponse.fromJson(jsonResult); | ||
| } |
There was a problem hiding this comment.
The Javadoc for this method indicates that the formType parameter is required. However, there is no validation to ensure it's not null. This is inconsistent with how the required path parameter id is handled. To improve robustness and provide clearer error messages to developers, you should add a null check for formType.
public TaxFormSummaryResponse getTaxFormSummary(
String id, String formType, RequestOptions requestOptions) throws ApiException, IOException {
// Add path params
Map<String, String> pathParams = new HashMap<>();
if (id == null) {
throw new IllegalArgumentException("Please provide the id path parameter");
}
pathParams.put("id", id);
if (formType == null) {
throw new IllegalArgumentException("Please provide the formType query parameter");
}
// Add query params
Map<String, String> queryParams = new HashMap<>();
queryParams.put("formType", formType);
String requestBody = null;
Resource resource =
new Resource(this, this.baseURL + "/accountHolders/{id}/taxFormSummary", null);
String jsonResult =
resource.request(
requestBody, requestOptions, ApiConstants.HttpMethod.GET, pathParams, queryParams);
return TaxFormSummaryResponse.fromJson(jsonResult);
}
This PR contains the automated changes for the
balanceplatformservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.