-
Notifications
You must be signed in to change notification settings - Fork 144
[TEST] [checkout] Code generation: update services and models #1659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates recent updates from the Adyen OpenAPI specification into the checkout service models. The changes primarily involve adding new fields to existing request and response objects, enhancing the data available for payment processing and stored payment methods. This ensures the API client remains synchronized with the latest API definitions, providing extended functionality and data points for checkout operations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request contains automated changes from a code generation process, which updates several model classes in the checkout service. The changes primarily involve adding new fields, such as merchantReference to CheckoutForwardRequest and CheckoutForwardResponse, and cardBin to StoredPaymentMethodResource. Additionally, new ALIPAY_PLUS payment method types have been added to the StoredPaymentMethodDetails enum. The generated code is consistent with the existing structure and patterns within the project. My review includes a suggestion to enhance test coverage for the newly added merchantReference field to ensure its behavior is verified.
| CheckoutForwardResponse response = recurringApi.forward(checkoutForwardRequest); | ||
|
|
||
| assertNull(response.getStoredPaymentMethodId()); // card is not tokenized | ||
| assertNull(response.getStoredPaymentMethodId()); // card is not tokenized |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CheckoutForwardResponse object now includes the merchantReference field. To improve test coverage for new features, it's a good practice to add assertions for new fields. In this test, since merchantReference is not set in the CheckoutForwardRequest, we can assert that it's null in the response.
| assertNull(response.getStoredPaymentMethodId()); // card is not tokenized | |
| assertNull(response.getStoredPaymentMethodId()); // card is not tokenized | |
| assertNull(response.getMerchantReference()); |
f29a998 to
2560c2f
Compare
This PR contains the automated changes for the
checkoutservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.