fix: Daemon artifact ship battle crash and a tip about destroying

[EttyKitty]

Purpose

• Fix a crash happening at ship battle initialization, following the daemonic artifact destruction.

Describe your changes/additions

• Role check fix.
• Add a tip into the daemonic artifact description, about what can happen.

What can/needs to be improved/changed

• The following battle is funny. I think there is only one greater daemon that gets EXPLODED in 1 turn.

Testing done

• Spawned daemonic artifacts and forced the battle - no crash, but the battle is weird, almost broken.

Related things and/or additional context

• None.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Summary by CodeRabbit

• New Features
  • Enhanced artefact descriptions now warn that destroying an item may trigger the materialisation of a daemonic presence.
  • Refined in-battle role validations offer a more consistent and streamlined experience during ship engagements.

Walkthrough

Our analysis indicates that this update refines two GameMaker Language scripts. In the scr_arti_descr script, the handling of the "daemonic" tag is modified: the description now warns that destroying the artifact may lead to the materialisation of the daemonic entity, rather than merely stating its presence. In the scr_ship_battle script, the conditional check for unit roles has been simplified. The condition now directly compares the unit’s role against three specific indices (obj_ini.role[100][5], obj_ini.role[100][11], and obj_ini.role[100][7]), removing the previous reliance on an additional array element from obj_ncombat.role[cooh, va]. There are no changes to any exported or public entities in these modifications.

Possibly related PRs

• fix: Daemonworld exterminatus disposition hit #668: This PR also addresses the implementation of daemonic entity mechanics, specifically within related narrative contexts, by adjusting code that relates to artefact-triggered daemonic materialisation.

Suggested labels

PR: Fix, Size: Small

Suggested reviewers

• OH296
• Blogaugis

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ba9fce0 and b5a9a6e.

📒 Files selected for processing (2)

• scripts/scr_arti_descr/scr_arti_descr.gml (1 hunks)
• scripts/scr_ship_battle/scr_ship_battle.gml (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

`**/*.gml`: - Macro constants require a space between the constant name and value. Without it, the compiler will throw an error. I.e. `#macro ARR_body_parts["arm"]` will crash the ...

**/*.gml: - Macro constants require a space between the constant name and value. Without it, the compiler will throw an error. I.e. #macro ARR_body_parts["arm"] will crash the game, because there is no space between the array and the name of the macro.

• Color codes in the code shouldn't have any spaces in their id. I.e., color code # 80 bf40 will crash the game.

• scripts/scr_arti_descr/scr_arti_descr.gml
• scripts/scr_ship_battle/scr_ship_battle.gml

`**/*.gml`: - Having humanly understandable and maintainable code is always the top most priority. - DRY (Don't repeat yourself) principle is also very important.

**/*.gml: - Having humanly understandable and maintainable code is always the top most priority.

• DRY (Don't repeat yourself) principle is also very important.

• scripts/scr_arti_descr/scr_arti_descr.gml
• scripts/scr_ship_battle/scr_ship_battle.gml