feat: ship-stats

[Blogaugis]

Purpose of the PR

This PR aims to achieve several goals:
Create a low-budged or renegade option for ship building;
Make space combat more viable, especially for renegade chapters.

Describe the solution

Introduce new variants of ships for several factions, including the player's.

Describe alternatives you've considered

Make existing ships build-able via alternative means (Such as chapter forge).

Testing done

• Compilation;
• Ship purchase or forging;
• Land force loading and unloading;
• Space travel;
• Space Combat;
• Bombardment;
• Land attack;
• Artifact and STC collecting.

Related links

https://discord.com/channels/714022226810372107/1342830023350157312

[OH296]

Most important is to fill in the new_player_ship function thats where most of the player ship data is set

[OH296]

So i've been thinking about my preferred method for implementation and i'm thinking of addin a raiding/piracy option to fleets in system which will naturally have the down side of teh imperial navy will zero in on you, we can then use the forge to retrofit captured ships from piracy? Don't know how this sounds to you. I've almost finished my major overhaul of sprites and modding and then i'm thinking i'll make a priority out of this?

[Blogaugis]

Most important is to fill in the new_player_ship function thats where most of the player ship data is set

Noted, though, I'd like to add these ships to other factions - other imperials, traitors and CSMs - as well.

So i've been thinking about my preferred method for implementation and i'm thinking of addin a raiding/piracy option to fleets in system which will naturally have the down side of teh imperial navy will zero in on you, we can then use the forge to retrofit captured ships from piracy? Don't know how this sounds to you. I've almost finished my major overhaul of sprites and modding and then i'm thinking i'll make a priority out of this?

Ships are valuable commodity, and I don't really like to abstract them. Still, some abstraction is needed - It would be nice to be able to track factions transport capacity, which shows how many merchant ships a faction has, and in turn means the potential the player can earn from raiding/piracy. Not sure if this value should be shown to the player, or visible only in debug mode.
This probably begs for yet another idea discussion.

If we double down on abstraction and simple approach, I imagine this - make use of battle barge trade values (the more valuable the planets, the more potential earnings in requisition per turn) by making piracy earn, let's say, 10 times the BBT, but this nukes the influence, disposition and skyrockets corruption. The requisition acquired can then be used to build ships.

I think we need to make smaller and/or simpler vessels build-able on hive worlds, temperate and worlds that have shipyard planetary feature. The violent solutions to earning ships are good, but I think options to build them should be a priority.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Blogaugis]

But frankly, the whole naval code is asking for a refactor of some kind, stuff scattered across numerous files is complicated to keep track of.

[Blogaugis]

Backtracking a bit to the simple approach of raiding/piracy:
Player is capable to issue the piracy/raiding order; We naturally have to consider - when the player can issue the order?
Should the player be able to issue the order, when it should logically have no effect (let's say in a system with a single several dead worlds only)? Should the player be able to issue the order on non-imperial controlled worlds?

Then we go to effects: So, supposedly, the imperial fleet will go after the player, if the player engages in piracy/raiding.
How much raiding is needed for navy to get off the Nids that they are likely going to be stuck on? Are we also going to see jank like player raiding ork systems, to see imperials going after them?

Even in simplistic terms, this is a pretty complex issue, and I'm not sure how you plan to make this, to not come off as jank. I'm going to search for a discussion in discord to discuss, or create a new one.

[github-actions]

This PR is marked as stale, because it has been open for 7 days with no activity.