-
Notifications
You must be signed in to change notification settings - Fork 44
feat: Attempts to rework the combat log #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Attempts to rework the combat log #332
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
This PR is marked as stale, because it has been open for 7 days with no activity. |
|
Closed, due to being omega old and this #726 PR doing everything this was, but better and actually working. |
Summary by Sourcery
Rework the combat log system by refactoring variable names and message handling logic for improved clarity and maintainability. Introduce a new function to handle string arrays and enhance message color handling with additional conditions.
New Features:
array_combine_stringsto handle string arrays by combining unique items and formatting them appropriately.Enhancements: