Added --ts=dynamic parameter to state install in order to use dynamic imports.
#3681
Conversation
|
Failing tests are test timeouts unrelated to this PR. |
| @@ -0,0 +1,60 @@ | |||
| package request | |||
There was a problem hiding this comment.
I renamed this file from evaluate.go. All of the content here previously existed and has not changed. As you can see, it calls something called buildCommitTarget.
This PR actually calls evaluate, so that call should live in evaluate.go.
| @@ -1,12 +1,30 @@ | |||
| package request | |||
There was a problem hiding this comment.
Despite what it looks like, this file's contents are entirely new. As mentioned in a prior comment, this file already existed, but called something else; it was mis-named, and I've fixed that here.
| } | ||
|
|
||
| if script.Dynamic() { | ||
| return nil, errs.New("Script cannot be a dynamic_solve") // forgot to call script.SetDynamic(false) earlier |
There was a problem hiding this comment.
Defensive programming.
|
Note: I will be flagging Nathan for final review so-as not to overburden him with the initial review. |
|
@Naatan will you please force-merge this? The fact this is not a DX ticket is preventing automations from allowing a merge. Maybe consider turning off some automations to avoid this going forward. |
See https://github.com/ActiveState/TheHomeRepot/pull/16871 for an example of this in action.