Skip to content

Log a warning if a depot artifact to undeploy does not exist. #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchell-as merged 3 commits into from
Apr 16, 2025
Merged

Log a warning if a depot artifact to undeploy does not exist. #3673

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d40d73c
Log a warning if a depot artifact to undeploy does not exist.
mitchell-as Apr 16, 2025
7667287
Merge branch 'version/0-48-0-RC1' into mitchell/dx-3243
mitchell-as Apr 16, 2025
693ee3c
Merge branch 'version/0-48-0-RC1' into mitchell/dx-3243
mitchell-as Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/runtime/depot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,11 @@ func (d *depot) Undeploy(id strfmt.UUID, relativeSrc, path string) error {

// Perform uninstall based on deployment type
if err := smartlink.UnlinkContents(filepath.Join(d.Path(id), relativeSrc), path); err != nil {
return errs.Wrap(err, "failed to unlink artifact")
if os.IsNotExist(err) {
logging.Warning("artifact no longer exists: %s", filepath.Join(d.Path(id), relativeSrc))
} else {
return errs.Wrap(err, "failed to unlink artifact")
}
}

// Re-link or re-copy any files provided by other artifacts.
Expand Down