Skip to content

When deleting cached depot artifacts, ensure ID is set. #3667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchell-as merged 1 commit into from
Mar 17, 2025
Merged

When deleting cached depot artifacts, ensure ID is set. #3667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pkg/runtime/depot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,10 +485,12 @@ func (d *depot) removeStaleArtifacts() error {
var totalSize int64
unusedArtifacts := make([]*artifactInfo, 0)

for _, info := range d.config.Cache {
for id, info := range d.config.Cache {
if !info.InUse {
totalSize += info.Size
unusedArtifacts = append(unusedArtifacts, info)
unusedInfo := *info
unusedInfo.id = id // id is not set in cache since info is keyed by id
unusedArtifacts = append(unusedArtifacts, &unusedInfo)
}
}
logging.Debug("There are %d unused artifacts totaling %.1f MB in size", len(unusedArtifacts), float64(totalSize)/float64(MB))
Expand Down
Loading