Remove TreeBase readTopology() and writeTopology()#2180
Open
danrbailey wants to merge 1 commit intoAcademySoftwareFoundation:feature/iofrom
Open
Remove TreeBase readTopology() and writeTopology()#2180danrbailey wants to merge 1 commit intoAcademySoftwareFoundation:feature/iofrom
danrbailey wants to merge 1 commit intoAcademySoftwareFoundation:feature/iofrom
Conversation
Signed-off-by: Dan Bailey <danbailey@ilm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes TreeBase::readTopology() and TreeBase::writeTopology() pure virtual and moves the old backwards-compatibility code (reading and writing
int32_t(1)) intoTree::readTopology()andTree::writeTopology(). This does not affect ABI because the vtable is the same regardless of whether there is an implementation for the base class or not.Multi-buffer trees were never supported since OpenVDB was open-sourced. In theory this will affect anyone who is sub-classing TreeBase, however it is expected to be very rare if anyone is doing this at all and the fix is trivial (to include the same
int32_t(1)code in their readTopology and writeTopology).