Skip to content

Conversation

@cedrik-fuoco-adsk
Copy link

Link the Issue(s) this Pull Request is related to.

Fixes #1173

Summarize your change.

  • Updated the Windows Debug library postfix to _d to match Python’s expected debug naming convention.
  • Fixed pybind11 GIL assertion risk by lazily initializing _value_to_any (avoid constructing py::none() during static initialization) in otio_utils.cpp

Describe the reason for the change.

OpenRV builds OTIO from source to avoid compatibility issues with its custom Python distribution.
When pairing Debug OTIO with Debug Python on Windows, I ran into:

  • A Debug-postfix mismatch (Python expects _d), which breaks resolution/loading of pyd.
  • pybind11 GIL assertions caused by creating Python objects during static initialization (before the interpreter/GIL is guaranteed to be ready).

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 16, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cedrik-fuoco-adsk / name: Cédrik Fuoco (38b0da1)

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@5cb38bc). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1991   +/-   ##
=======================================
  Coverage        ?   85.15%           
=======================================
  Files           ?      181           
  Lines           ?    12783           
  Branches        ?     1206           
=======================================
  Hits            ?    10885           
  Misses          ?     1715           
  Partials        ?      183           
Flag Coverage Δ
py-unittests 85.15% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ntimelineio/opentimelineio-bindings/otio_utils.cpp 77.77% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cb38bc...38b0da1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JeanChristopheMorinPerso
Copy link
Member

Interesting finding! We fixed a similar issue 4 years ago in #1070.

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
@darbyjohnston darbyjohnston force-pushed the fix-windows-debug-with-python-debug branch from 968ecb9 to 38b0da1 Compare February 12, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants