Remove patch version from namespace#1979
Remove patch version from namespace#1979darbyjohnston merged 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1979 +/- ##
==========================================
+ Coverage 85.13% 85.15% +0.01%
==========================================
Files 181 181
Lines 12783 12783
Branches 1206 1206
==========================================
+ Hits 10883 10885 +2
+ Misses 1717 1715 -2
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@reinecke Thinking about this after the meeting, I just wanted to call out that this PR does change the API by replacing So if people are using this in their C++ code: They will have to update it to this: We provide the |
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
|
We discussed this at the TSC meeting today so I'm going to go ahead and merge it... |
5cb38bc
into
AcademySoftwareFoundation:main
Fixes #1978
This PR removes the patch version from the OTIO namespace. As pointed out in #1978, patch versions shouldn't change the API, but we were making every release unique by including the patch number in the API itself.