Fixes for the C++ exports#1959
Merged
darbyjohnston merged 2 commits intoAcademySoftwareFoundation:mainfrom Oct 27, 2025
Merged
Conversation
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## main #1959 +/- ##
==========================================
+ Coverage 84.11% 85.10% +0.98%
==========================================
Files 198 181 -17
Lines 22241 12768 -9473
Branches 4687 1206 -3481
==========================================
- Hits 18709 10866 -7843
+ Misses 2610 1719 -891
+ Partials 922 183 -739
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
rogernelson
approved these changes
Oct 27, 2025
60171a4
into
AcademySoftwareFoundation:main
56 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of issues with the C++ exports:
OPENTIMELINEIO_IMPORT_TYPEmacroOTIO_SHARED_LIBSinstead ofBUILD_SHAREDinsrc/opentime/CMakeLists.txtandsrc/opentimelineio/CMakeLists.txtOPENTIME_STATICandOTIO_STATICwhen building as a static library. These are defined automatically if you use the OTIO CMake config:find_package(OpenTimelineIO)OPENTIMELINIO->OPENTIMELINEIO