Temporarily disable check_manifest on MinGW#1935
Temporarily disable check_manifest on MinGW#1935darbyjohnston merged 4 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## main #1935 +/- ##
==========================================
+ Coverage 84.11% 85.00% +0.88%
==========================================
Files 198 181 -17
Lines 22241 13074 -9167
Branches 4687 1206 -3481
==========================================
- Hits 18709 11113 -7596
+ Misses 2610 1778 -832
+ Partials 922 183 -739
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
meshula
left a comment
There was a problem hiding this comment.
Thanks for addressing this. I agree with your assessment that we lack resources to maintain mingw builds at the moment. Can I suggest we comment it out for 30 days, and post an RFC in OTIO issues and ASWF Slack requesting a maintainer, and if none steps up, we delete it as you propose?
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
|
I looked into it some more, and the part that is failing is the I skimmed their PRs and didn't see any related to the error we are seeing, so maybe for now we just disable that step. I updated the PR and added a todo comment to fix it at some point. |
f970d77
into
AcademySoftwareFoundation:main
…n#1935) * Remove MinGW CI jobs Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com> * Comment out the MinGW job Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com> * Try just disabling the check-manifest and lint check Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com> * Add comment Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com> --------- Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com> Signed-off-by: luzpaz <luzpaz@users.noreply.github.com>
This PR removes the MinGW CI job. It seems to have intermittent failures and I don't think we have the resources to troubleshoot it each time:
https://github.com/darbyjohnston/OpenTimelineIO/actions/runs/17500902789/job/49713367017
Edit: Note that this doesn't remove the various fixes for MinGW, just the CI job.