Remove unused path from the C++ install#1882
Merged
meshula merged 1 commit intoAcademySoftwareFoundation:mainfrom May 2, 2025
Merged
Remove unused path from the C++ install#1882meshula merged 1 commit intoAcademySoftwareFoundation:mainfrom
meshula merged 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1882 +/- ##
==========================================
+ Coverage 84.11% 84.72% +0.61%
==========================================
Files 198 177 -21
Lines 22241 12809 -9432
Branches 4687 1191 -3496
==========================================
- Hits 18709 10853 -7856
+ Misses 2610 1773 -837
+ Partials 922 183 -739
Flags with carried forward coverage won't be shown. Click here to find out more. see 135 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ssteinbach
approved these changes
May 1, 2025
Collaborator
ssteinbach
left a comment
There was a problem hiding this comment.
Whoops! nice catch. LGTM
Collaborator
|
deps was for interring libraries, I can't think of a reason to inter it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes an unused path from the C++ installation. Previously the "any" and "optional" headers were installed into
${OTIO_RESOLVED_CXX_INSTALL_DIR}/include/opentimelineio/deps), but they were removed with the transition to C++17.Currently trying to use the OTIO CMake config gives this error:
It looks like the Imath dependency is not installed to
deps, but alongside OTIO:An alternative fix would be to install Imath into
deps, but I'm not sure which is more appropriate.