Skip to content

Remove unused path from the C++ install#1882

Merged
meshula merged 1 commit intoAcademySoftwareFoundation:mainfrom
darbyjohnston:cxx_install_fix
May 2, 2025
Merged

Remove unused path from the C++ install#1882
meshula merged 1 commit intoAcademySoftwareFoundation:mainfrom
darbyjohnston:cxx_install_fix

Conversation

@darbyjohnston
Copy link
Contributor

This change removes an unused path from the C++ installation. Previously the "any" and "optional" headers were installed into ${OTIO_RESOLVED_CXX_INSTALL_DIR}/include/opentimelineio/deps), but they were removed with the transition to C++17.

Currently trying to use the OTIO CMake config gives this error:

CMake Error in CMakeLists.txt:
  Imported target "OTIO::opentimelineio" includes non-existent path

    "install/include/opentimelineio/deps"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

It looks like the Imath dependency is not installed to deps, but alongside OTIO:

$ ls install/include/
Imath  opentime  opentimelineio

An alternative fix would be to install Imath into deps, but I'm not sure which is more appropriate.

Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.72%. Comparing base (c0e97b0) to head (49b1a01).
Report is 59 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1882      +/-   ##
==========================================
+ Coverage   84.11%   84.72%   +0.61%     
==========================================
  Files         198      177      -21     
  Lines       22241    12809    -9432     
  Branches     4687     1191    -3496     
==========================================
- Hits        18709    10853    -7856     
+ Misses       2610     1773     -837     
+ Partials      922      183     -739     
Flag Coverage Δ
py-unittests 84.72% <ø> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 135 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0aac2b...49b1a01. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! nice catch. LGTM

@meshula
Copy link
Collaborator

meshula commented May 2, 2025

deps was for interring libraries, I can't think of a reason to inter it.

@meshula meshula merged commit c125d9c into AcademySoftwareFoundation:main May 2, 2025
62 checks passed
@darbyjohnston darbyjohnston deleted the cxx_install_fix branch November 1, 2025 15:21
@reinecke reinecke added this to the Public Beta 18 milestone Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants