Drop dead OTIO_IMATH_LIBS cmake option#1874
Merged
jminor merged 1 commit intoAcademySoftwareFoundation:mainfrom Apr 20, 2025
Merged
Drop dead OTIO_IMATH_LIBS cmake option#1874jminor merged 1 commit intoAcademySoftwareFoundation:mainfrom
jminor merged 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
It seems to be a relic from Imath2 where it would have made sense as it required a custom find OpenEXR script. However the option is dead (and appears to have ever been) and is not usefull for Imath3 anyways. Signed-off-by: Julius Künzel <julius.kuenzel@kde.org>
github-actions
bot
added
the
submodules
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## main #1874 +/- ##
==========================================
+ Coverage 84.11% 84.72% +0.61%
==========================================
Files 198 177 -21
Lines 22241 12809 -9432
Branches 4687 1191 -3496
==========================================
- Hits 18709 10853 -7856
+ Misses 2610 1773 -837
+ Partials 922 183 -739
Flags with carried forward coverage won't be shown. Click here to find out more. see 131 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
meshula
approved these changes
Apr 19, 2025
Collaborator
|
lgtm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems to be a relic from Imath2 where it would have made sense as it required a custom find OpenEXR script. However the option is dead (and appears to have ever been) and is not usefull for Imath3 anyways.
As discussed with @meshula on Slack