Allow build system to use rapidjson from the system#1859
Allow build system to use rapidjson from the system#1859darbyjohnston merged 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Julius Künzel <julius.kuenzel@kde.org>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## main #1859 +/- ##
==========================================
+ Coverage 84.11% 84.72% +0.60%
==========================================
Files 198 177 -21
Lines 22241 12807 -9434
Branches 4687 1191 -3496
==========================================
- Hits 18709 10851 -7858
+ Misses 2610 1773 -837
+ Partials 922 183 -739
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
94ba8d4 to
30812bb
Compare
|
The readthedocs.org failure seems unrelated? |
|
Unrelated; sometimes readthedocs has these failures, possibly a network error. I'm not sure how to re-run the job, it's separate from the Github actions. Maybe wait for a bit and try pushing another change to try again. |
|
I restarted the RTD build - sometimes that does flake out, sorry |
|
Thanks for the changes; I agree about the fallback, the Imath behavior could be changed in a separate PR. |
d6fff83
into
AcademySoftwareFoundation:main
Summarize your change.
For (Linux) distro packaging it is common to use system packages instead of submodules and co.
With this option one can ask to use the system rapidjson with CMake flag instead of maintaining custom patches such as https://build.opensuse.org/projects/KDE:Applications/packages/opentimelineio/files/0001-Use-system-rapidjson.patch?expand=1
Note: if
OTIO_FIND_RAPIDJSONisONbut rapidjson is not found cmake fails. This behavior is different toOTIO_FIND_IMATHwhere it will just continue withsrc/depsas a fallback. However I think if the user explicitly request the system package it makes more sense to fail if not found. In my opinion this should be changed for Imath as well, but that is offtopic for this PR