fix: SG-41698: Add Alt modifier check for mouse wheel events#1060
Merged
bernie-laberge merged 3 commits intoAcademySoftwareFoundation:mainfrom Mar 7, 2026
Merged
Conversation
Signed-off-by: TJ Jackson <tj.jackson@dreamworks.com>
tjjackson
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
bernie-laberge
changed the title
bernie-laberge
approved these changes
Jan 14, 2026
Contributor
bernie-laberge
left a comment
bernie-laberge
left a comment
There was a problem hiding this comment.
Thank you @tjjackson !
Signed-off-by: TJ Jackson <tj.jackson@dreamworks.com>
Contributor
|
@tjjackson I think you forgot to format your code. You can use |
Contributor
|
Sorry @tjjackson, the formatting error was my bad: the formatter hadn't ran on the code I proposed to you because I never committed it. |
Signed-off-by: TJ Jackson <tj.jackson@dreamworks.com>
Contributor
Author
|
Yeah I copied-pasted it and didn't think to run pre-commit again, should be good now |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates OpenRV’s Qt event translation so mouse wheel “up/down” direction is derived from the correct QWheelEvent::angleDelta() axis when a horizontal-scroll modifier is pressed (Alt on Linux/Windows, Shift on macOS).
Changes:
- Add platform-specific modifier selection to detect horizontal scrolling for wheel events.
- Use
angleDelta().x()instead ofangleDelta().y()when the horizontal-scroll modifier is active.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cedrik-fuoco-adsk
changed the title
bernie-laberge
merged commit 0d61a84
into
AcademySoftwareFoundation:main
25 checks passed
pascalandr
pushed a commit
to Pagecran/OpenRV
that referenced
this pull request
Mar 12, 2026
…SoftwareFoundation#1060) ### Linked issues ### Summarize your change. Added a check for Alt modifier to QTTranslator::sendMouseWheelEvent() ### Describe the reason for the change. The Alt key combined with the mouse wheel triggers horizontal scrolling, and will be reported in angleDelta().x() instead of angleDelta().y(). I added a check for the Alt modifier for whether to use angleDelta().x() or angleDelta().y() as the delta for determining if the wheel is moving down or up. ### Describe what you have tested and on which operating system. Successfully tested on Rocky Linux 9.5 ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. --------- Signed-off-by: TJ Jackson <tj.jackson@dreamworks.com>
eloisebrosseau
pushed a commit
to eloisebrosseau/OpenRV
that referenced
this pull request
Apr 1, 2026
…SoftwareFoundation#1060) ### Linked issues ### Summarize your change. Added a check for Alt modifier to QTTranslator::sendMouseWheelEvent() ### Describe the reason for the change. The Alt key combined with the mouse wheel triggers horizontal scrolling, and will be reported in angleDelta().x() instead of angleDelta().y(). I added a check for the Alt modifier for whether to use angleDelta().x() or angleDelta().y() as the delta for determining if the wheel is moving down or up. ### Describe what you have tested and on which operating system. Successfully tested on Rocky Linux 9.5 ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. --------- Signed-off-by: TJ Jackson <tj.jackson@dreamworks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Summarize your change.
Added a check for Alt modifier to QTTranslator::sendMouseWheelEvent()
Describe the reason for the change.
The Alt key combined with the mouse wheel triggers horizontal scrolling, and will be reported in angleDelta().x() instead of angleDelta().y(). I added a check for the Alt modifier for whether to use angleDelta().x() or angleDelta().y() as the delta for determining if the wheel is moving down or up.
Describe what you have tested and on which operating system.
Successfully tested on Rocky Linux 9.5
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.