fix(oiiotool): -d SUBIMAGENAME.* didn't work properly#5048
Open
lgritz wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Open
fix(oiiotool): -d SUBIMAGENAME.* didn't work properly#5048lgritz wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
-d SUBIMAGENAME.* didn't work properly#5048lgritz wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
The docs described a syntax where you could use `-d` to change the data type of all channels in one subimage of a multi-subimage image. But it didn't work, as revealed in 5047. Fixes 5047 Signed-off-by: Larry Gritz <lg@larrygritz.com>
Collaborator
Author
|
I am not familiar with the C++ syntax but logic looks good ! |
…ize it by 'subimage{:02}'
Signed-off-by: Larry Gritz <lg@larrygritz.com>
Collaborator
Author
Good suggestion. I have amended the PR with such a test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs described a syntax where you could use
-dto change the data type of all channels in one subimage of a multi-subimage image. But it didn't work, as revealed in #5047.Fixes #5047