build: Remove support for deprecated Intel icc compiler#5040
Open
lgritz wants to merge 3 commits intoAcademySoftwareFoundation:mainfrom
Open
build: Remove support for deprecated Intel icc compiler#5040lgritz wants to merge 3 commits intoAcademySoftwareFoundation:mainfrom
lgritz wants to merge 3 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Intel icc is deprecated and hasn't had a release for a few years. It's holding us back, both by making us work around an ever growing number of icc bugs and limitation that will never be fixed, as well as not allowing us to upgrade minimum versions of certain dependencies, because icc can't correctly compiler newer versions (as an example, it cannot use a 'fmt' library newer than the oldest we support, 7.0). So it's time to thank it for its service and put it on the ice floe for the polar bears to eat. This is of course in main (future 3.2), and will not be backported to release branches, since we never stop support of a dependency or toolchain of existing releases. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Larry Gritz <lg@larrygritz.com>
Collaborator
Author
|
Any objections to dropping icc support, or does anybody see anything unwise about the code I'm removing in this PR? |
Collaborator
|
No objections from me. If icc is still seeing regular industry use, I imagine we'll hear about it in the issues / PRs. |
Collaborator
Author
|
icc is considered deprecated by its maker, Intel. I really hope nobody is still depending on it. But if they are, they are by definition stuck on a several-years-old toolchain, so I figure they ought to be able to make do with OIIO 3.1 or earlier as well. |
Collaborator
|
Hey, OIIO 3.1 isn't too shabby. I say, let 'em suffer. |
Collaborator
Author
|
Last chance for comments. I will merge this at the end of the week if nobody objects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intel icc is deprecated and hasn't had a release for a few years. It's holding us back, both by making us work around an ever growing number of icc bugs and limitation that will never be fixed, as well as not allowing us to upgrade minimum versions of certain dependencies, because icc can't correctly compile newer versions (as an example, it cannot use a 'fmt' library newer than the oldest we support, 7.0).
So it's time to thank icc for its service and put it on the ice floe for the polar bears to eat. This is of course in main (future 3.2), and will not be backported to release branches, since we never stop support of a dependency or toolchain of existing releases. People requiring icc for whatever reason may keep using OIIO 3.1 or older.
We will continue to support and test icx, the fully supported Intel LLVM-based compiler.