ci: build_Ptex.bash should build Ptex using C++17 #4978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't specify anything, it seems that Ptex will think it's using C++98, which it is in fact not capable of doing. Meanwhile, since OIIO's own minimum requirement is C++17, it certainly meand that any compiler we're using can support 17 as a minimum when building Ptex as well. Signed-off-by: Larry Gritz <lg@larrygritz.com>
EmilDohne
approved these changes
Dec 15, 2025
Contributor
EmilDohne
left a comment
EmilDohne
left a comment
There was a problem hiding this comment.
Looks like CI failures are unrelated, LGTM
lgritz
merged commit febafce
into
AcademySoftwareFoundation:main
29 of 32 checks passed
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Dec 17, 2025
…ndation#4978) If we don't specify anything, it seems that Ptex will think it's using C++98, which it is in fact not capable of doing. Meanwhile, since OIIO's own minimum requirement is C++17, it certainly meand that any compiler we're using can support 17 as a minimum when building Ptex as well. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't specify anything, it seems that Ptex will think it's using C++98, which it is in fact not capable of doing.
Meanwhile, since OIIO's own minimum requirement is C++17, it certainly meand that any compiler we're using can support 17 as a minimum when building Ptex as well.