[cuebot][FIX] Hardware tags update on Host restart #2125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-ubi
requested review from
DiegoTavares,
lithorus and
ramonfigueiredo
as code owners
anton-ubi
changed the title
anton-ubi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When an RQD instance restarts with a different version, the version tag (
rqdv-X) in CueCommander is not being updated. The tags remain stuck at the first registered version despite the RQD instance reporting the correct new version on startup.Root Cause
There is no mechanism to update host tags when an existing RQD instance reconnects with different version information. Tags are only set during initial host creation and remain static afterwards.
Solution
updateHostTagsmethod to handle tag updates on host reconnectionHostTagType.HARDWAREfor RQD tags to distinguish them from user-added manual tagsNote: HostTagType.HARDWARE seemed unused. I don't know if a different usage was planned for it. It seems a good contender to segregate easily tags added at creation from manual tags added by the user later.
Testing
Update related unit tests to reflect the new tag ordering after the type classification change.
Add coverage to ensure manual tags are left untouched.