[RQD][FIX] Windows log rotation retries #2121
Merged
+82
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-ubi
requested review from
DiegoTavares,
lithorus and
ramonfigueiredo
as code owners
anton-ubi
changed the title
DiegoTavares
approved these changes
Jan 5, 2026
Collaborator
|
Hi @anton-ubi, Thanks for your contribution, I am finishing one extra review. I will merge or comment on your code soon |
Collaborator
ramonfigueiredo
left a comment
ramonfigueiredo
left a comment
There was a problem hiding this comment.
Hi @anton-ubi, great job.
Some minor changes before merge your PR to the master.
Thanks for your contribution again.
Contributor
Author
|
Changes addressed. Thanks for your feedback! |
ramonfigueiredo
merged commit 624775b
into
AcademySoftwareFoundation:master
22 checks passed
Collaborator
|
Great job, @anton-ubi . Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attempts retry when the RQD log rotation fails on Windows with error
[WinError 32] The process cannot access the file because it is being used by another process.Rationale
On Windows, log rotation may fail if the log file is temporarily locked by another process. Although this scenario was previously handled by silently ignoring the failure, it could still lead to logs not being rotated as expected.
Changes
If log rotation fails, it is now retried up to three times, with a minimal delay between each attempt. This approach helped us on our end limiting warning messages.
The implementation uses a strategy pattern, to prevent hard-to-maintain OS-dependent if/else logic cases for future platform-specific specializations.