-
Notifications
You must be signed in to change notification settings - Fork 481
Update documentation for 2.5 release #2202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for 2.5 release #2202
Conversation
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
|
Do we want to mention that
|
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
remia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thanks Doug.
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
carolalynn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made one small comment re: negative mirroring but it's minor, happy to approve as is. Great work and thank you Doug :)
| In addition, the new configs make expanded use of OCIO v2 features such as File Rules and | ||
| Viewing Rules and add a virtual display to support use with ICC monitor profiles. | ||
|
|
||
| Please take note that the display color spaces in the new configs pass through negative |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this should be added to the "breaking changes" section somehow as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had originally added something there, but then removed it because it is not really a breaking change. In other words, the ACES 1 configs still clamp negs as before. The ACES 2 config mirrors, but I felt that it was really a new config and so this wasn't a change to existing behavior and that it was therefore sufficient to describe mirroring in the section on the new ACES 2 configs. (Yes, external ACES 2 configs were released in the spring, but we did bump the major version number of those.)
Anyway, that was the logic, but am open to adding something, if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree with you, it's not really breaking... let's leave it for now, and if we get a lot of feedback/questions around it, we can revisit making it more prominent.
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Added a What's New page for the 2.5 release and made updates to existing documentation where necessary based on the new features.
A preliminary description has been provided, but more work is needed for the config merge and hue curve transforms. To be done in a follow-up.
I added a "Breaking Changes" section at the top for people that aren't going to read the whole What's New, but maybe that is too dramatic? Open to suggestions for how to do that better.