Fix missing origin annotations for MDL#2806
Fix missing origin annotations for MDL#2806jstone-lucasfilm merged 4 commits intoAcademySoftwareFoundation:mainfrom
Conversation
These are based on the node paths and were missing for the second input of a unit transform node and input sockets of node graphs.
|
On second thought I'm not that sure anymore about the change for the unit transform node. Do we want multiple nodes with the same path? I don't know where paths are used elsewhere and would leave that decision to others. If the decision is that multiple nodes with the same path is ok/the correct thing to do, then we might want to avoid for the MDL backend multiple parameters with the same origin annotations. These are used by integrations to map arguments for the MaterialX material to parameters of the generated MDL code. The 2nd input of the unit transform node does not have a direct counterpart in the original material. Mapping the value from that path would be logically wrong (and doesn't work anyway because of type mismatches). Instead of asking all integrations to add code for this special case it is probably better not to emit the origin annotation in this case (as before my change). |
|
@jreichel-nvidia This single-line change looks fine to me, assuming it addresses the issue you're encountering in MDL. Can you provide a quick description of the case that it addresses? |
|
Actually I have difficulties finding the commonality of the affected cases. In most cases the path is set somewhere later, but in a few cases these locations are not hit. Looks like it has to do with nodedef nodes, but I suppose there is something special/different with those cases that I don't see. Here is the list of the generated MDL materials with the affected paths: |
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks fine to me, thanks @jreichel-nvidia!
00ede1e
into
AcademySoftwareFoundation:main
These are based on the node paths and were missing for the second input of a unit transform node and input sockets of node graphs.