Add retroreflective to specular BSDFs#2783
Merged
jstone-lucasfilm merged 13 commits intoAcademySoftwareFoundation:mainfrom Mar 31, 2026
Merged
Add retroreflective to specular BSDFs#2783jstone-lucasfilm merged 13 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm merged 13 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks great to me, @msuzuki-nvidia, and I'd like to aim to include it in MaterialX v1.39.5 if possible.
Let's get additional feedback from others in the physically based shading community and see how it looks to them.
jstone-lucasfilm
requested review from
jstone-lucasfilm,
niklasharrysson and
portsmouth
Minor typo fix Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks good to me, @msuzuki-nvidia, and I had just one recommendation for controlling the new behavior of FilePath::createDirectory.
jstone-lucasfilm
approved these changes
Mar 31, 2026
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
Great work, thanks @msuzuki-nvidia!
jstone-lucasfilm
merged commit f6dc35f
into
AcademySoftwareFoundation:main
36 checks passed
ashwinbhat
added a commit
to autodesk-forks/MaterialX
that referenced
this pull request
Apr 2, 2026
Merge from main at Add retroreflective to specular BSDFs (AcademySoftwareFoundation#2783) f6dc35f (March 31)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
retroreflectiveboolean input to the specular BSDF nodes (dielectric_bsdf,conductor_bsdf,generalized_schlick_bsdf).retroreflectiveinput to node definitions inpbrlib_defs.mtlxAlso includes minor test infrastructure fixes:
FilePath::createDirectory()recursive to support nested output directoriesOslRendererbefore working directory changesblur.mtlxin MDL render tests due to material name mismatch