feat: fix a11y issues in tag component#658
Open
fateeand wants to merge 1 commit into
Open
Conversation
Contributor
Coverage report for library
Test suite run success1096 tests passing in 33 suites. Report generated by 🧪jest coverage report action from 7ca5a6f |
Contributor
Playwright test resultsDetails
|
TerranceKhumalo-absa
requested changes
Jun 8, 2026
|
|
||
| ngOnChanges(): void { | ||
| this.color = getCSSColor(this.color, this.document); | ||
| ngOnInit(): void { |
Collaborator
There was a problem hiding this comment.
Missing OnInit import and implements. Someone might accidentally change it and typescript won't catch the error :)
| it('should set aria-checked to true when selectable and selected', () => { | ||
| fixture.componentRef.setInput('selectable', true); | ||
| fixture.detectChanges(); | ||
| component.selectable = true; |
Collaborator
There was a problem hiding this comment.
I think component.selectable = true; might be redundant as we already set it here fixture.componentRef.setInput('selectable', true);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing accessibility issues in tag component
Validation rules:
Validated using Playwright accessibility tests, Lighthouse tool, and manual checks including keyboard tab navigation and screen reader testing.
Full doc with rules
Playwright axe-core validation results:
State before:
State after:
Checklist
Keyboard Navigation
All interactive elements are fully operable via keyboard only, including buttons, inputs, menus, dialogs, sliders, drag-and-drop, tree views, multi-selects, and composite widgets. No traps or dead ends.
Focus Management
Focus is visible, logical, moves in predictable order, trapped where necessary (modals/popovers), and restored after closing. Focus is perceivable in all interactive widgets.
Semantics / ARIA
Color / Contrast
Screen Reader / Assistive Technology
Responsive & Zoom
[N/A] Error Handling
[N/A] Dynamic Content / Updates
Interaction Feedback / States
[N/A] Authentication & Sensitive Actions
Predictable & Controllable UI
Release notes: