Skip to content

feat: fix a11y issues in tag component#658

Open
fateeand wants to merge 1 commit into
masterfrom
597-fix-a11y-issues-in-tag-component
Open

feat: fix a11y issues in tag component#658
fateeand wants to merge 1 commit into
masterfrom
597-fix-a11y-issues-in-tag-component

Conversation

@fateeand
Copy link
Copy Markdown
Collaborator

@fateeand fateeand commented Jun 5, 2026

Fixing accessibility issues in tag component

Validation rules:

Validated using Playwright accessibility tests, Lighthouse tool, and manual checks including keyboard tab navigation and screen reader testing.

Full doc with rules


Playwright axe-core validation results:

State before:

Component aria-roles color-contrast tabindex target-size
Tag - - -

State after:

Component aria-roles color-contrast tabindex target-size
Tag

Checklist

  • Keyboard Navigation
    All interactive elements are fully operable via keyboard only, including buttons, inputs, menus, dialogs, sliders, drag-and-drop, tree views, multi-selects, and composite widgets. No traps or dead ends.

  • Focus Management
    Focus is visible, logical, moves in predictable order, trapped where necessary (modals/popovers), and restored after closing. Focus is perceivable in all interactive widgets.

  • Semantics / ARIA

    • Semantic HTML is used correctly.
    • ARIA roles, states, and properties are applied only when needed.
    • All form fields, tables, and widgets (including autocomplete, tree selects, tree tables, drag-and-drop, sliders, and multi-selects) are properly labeled and accessible.
  • Color / Contrast

    • Text and interactive elements meet contrast requirements (≥4.5:1 normal text, ≥3:1 large text).
    • Focus and selection indicators are visually perceivable.
    • Color is not the only indicator of state.
  • Screen Reader / Assistive Technology

    • All content, labels, and dynamic updates are perceivable via screen readers.
    • Live regions announce status messages, alerts, modals, notifications, and dynamic changes.
    • Interactive widgets provide proper announcements of selection and updates.
  • Responsive & Zoom

    • Components function correctly and remain readable at all viewport sizes and up to 200% zoom, including mobile and touch devices.
    • Prefer em/rem units over px where scaling is required.
  • [N/A] Error Handling

    • Errors are clearly identified visually and programmatically.
    • Form inputs use aria-describedby or aria-invalid for inline messages.
    • Instructions and suggestions are accessible.
  • [N/A] Dynamic Content / Updates

    • Status updates, alerts, notifications, and modals use live regions.
    • Updates do not disrupt focus or user control unexpectedly.
  • Interaction Feedback / States

    • All interactive states (hover, focus, active, disabled, drag-and-drop, reordering, multi-select) are visually perceivable.
  • [N/A] Authentication & Sensitive Actions

    • Inputs and actions involving sensitive data provide accessible instructions, feedback, and error messages.
  • Predictable & Controllable UI

    • Components behave consistently and predictably.
    • Popups, modals, autocomplete suggestions, drag-and-drop, and dynamic content allow user control.

Release notes:

  • Fix a11y issues in tag component

@fateeand fateeand linked an issue Jun 5, 2026 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

Coverage report for library

St.
Category Percentage Covered / Total
🔴 Statements 45.54% 3289/7223
🔴 Branches 40.74% 1426/3500
🔴 Functions 44.91% 627/1396
🔴 Lines 46.05% 3067/6660

Test suite run success

1096 tests passing in 33 suites.

Report generated by 🧪jest coverage report action from 7ca5a6f

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

Playwright test results

passed  82 passed

Details

stats  82 tests across 4 suites
duration  2 minutes, 44 seconds
commit  7ca5a6f
info  For details, download the Playwright report


ngOnChanges(): void {
this.color = getCSSColor(this.color, this.document);
ngOnInit(): void {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing OnInit import and implements. Someone might accidentally change it and typescript won't catch the error :)

it('should set aria-checked to true when selectable and selected', () => {
fixture.componentRef.setInput('selectable', true);
fixture.detectChanges();
component.selectable = true;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think component.selectable = true; might be redundant as we already set it here fixture.componentRef.setInput('selectable', true);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix a11y issues in tag component

2 participants