Skip to content

feat: fix a11y issues in divider component#657

Merged
fateeand merged 3 commits into
masterfrom
585-fix-a11y-issues-in-divider-component
Jun 9, 2026
Merged

feat: fix a11y issues in divider component#657
fateeand merged 3 commits into
masterfrom
585-fix-a11y-issues-in-divider-component

Conversation

@fateeand

@fateeand fateeand commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Fixing accessibility issues in divider component

Validation rules:

Validated using Playwright accessibility tests, Lighthouse tool, and manual checks including keyboard tab navigation and screen reader testing.

Full doc with rules


Playwright axe-core validation results:

State before:

Component aria-roles
Divider -

State after:

Component aria-roles
Divider

Checklist

  • [N/A] Keyboard Navigation
    All interactive elements are fully operable via keyboard only, including buttons, inputs, menus, dialogs, sliders, drag-and-drop, tree views, multi-selects, and composite widgets. No traps or dead ends.

  • [N/A] Focus Management
    Focus is visible, logical, moves in predictable order, trapped where necessary (modals/popovers), and restored after closing. Focus is perceivable in all interactive widgets.

  • Semantics / ARIA

    • Semantic HTML is used correctly.
    • ARIA roles, states, and properties are applied only when needed.
    • All form fields, tables, and widgets (including autocomplete, tree selects, tree tables, drag-and-drop, sliders, and multi-selects) are properly labeled and accessible.
  • [N/A] Color / Contrast

    • Text and interactive elements meet contrast requirements (≥4.5:1 normal text, ≥3:1 large text).
    • Focus and selection indicators are visually perceivable.
    • Color is not the only indicator of state.
  • [N/A] Screen Reader / Assistive Technology

    • All content, labels, and dynamic updates are perceivable via screen readers.
    • Live regions announce status messages, alerts, modals, notifications, and dynamic changes.
    • Interactive widgets provide proper announcements of selection and updates.
  • Responsive & Zoom

    • Components function correctly and remain readable at all viewport sizes and up to 200% zoom, including mobile and touch devices.
    • Prefer em/rem units over px where scaling is required.
  • [N/A] Error Handling

    • Errors are clearly identified visually and programmatically.
    • Form inputs use aria-describedby or aria-invalid for inline messages.
    • Instructions and suggestions are accessible.
  • [N/A] Dynamic Content / Updates

    • Status updates, alerts, notifications, and modals use live regions.
    • Updates do not disrupt focus or user control unexpectedly.
  • [N/A] Interaction Feedback / States

    • All interactive states (hover, focus, active, disabled, drag-and-drop, reordering, multi-select) are visually perceivable.
  • [N/A] Authentication & Sensitive Actions

    • Inputs and actions involving sensitive data provide accessible instructions, feedback, and error messages.
  • [N/A] Predictable & Controllable UI

    • Components behave consistently and predictably.
    • Popups, modals, autocomplete suggestions, drag-and-drop, and dynamic content allow user control.

Release notes:

  • Fix a11y issues in divider component

@fateeand fateeand linked an issue Jun 5, 2026 that may be closed by this pull request
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Coverage report for library

St.
Category Percentage Covered / Total
🔴 Statements 46.23% 3271/7076
🔴 Branches 41.7% 1416/3396
🔴 Functions 45.08% 623/1382
🔴 Lines 46.79% 3050/6518

Test suite run success

1076 tests passing in 33 suites.

Report generated by 🧪jest coverage report action from df622f0

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Playwright test results

passed  82 passed

Details

stats  82 tests across 4 suites
duration  2 minutes, 42 seconds
commit  df622f0
info  For details, download the Playwright report

Comment thread projects/cps-ui-kit/src/lib/components/cps-divider/cps-divider.component.ts Outdated
@fateeand fateeand merged commit 6f25125 into master Jun 9, 2026
11 checks passed
@fateeand fateeand deleted the 585-fix-a11y-issues-in-divider-component branch June 9, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix a11y issues in divider component

2 participants