Feature/469 intro dark alternative #480
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
There was a problem hiding this comment. @TerranceKhumalo-absa I'm not sure was it intended or not, so I'll just gather the list suspicious props in files: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| <div class="theme-controls"> | ||
| <button | ||
| class="theme-toggle-btn" | ||
| (click)="toggleMenu()" | ||
| [attr.aria-expanded]="menuOpen" | ||
| aria-label="Open appearance settings" | ||
| type="button"> | ||
| Customize | ||
| <span class="theme-toggle-caret">▾</span> | ||
| </button> | ||
| @if (menuOpen) { | ||
| <div class="menu-backdrop" aria-hidden="true" (click)="closeMenu()"></div> | ||
| <div class="theme-menu" aria-label="Appearance settings"> | ||
| <div class="theme-menu-header"> | ||
| <div class="theme-menu-title">Appearance</div> | ||
| <div class="theme-menu-subtitle">Theme, radius and dark base</div> | ||
| </div> | ||
| <section class="theme-section theme-section-theme" aria-label="Theme"> | ||
| <h4 class="theme-section-title">Theme</h4> | ||
| <div class="theme-options"> | ||
| <button | ||
| type="button" | ||
| class="theme-option" | ||
| [class.selected]="colorTheme() === 'neutral'" | ||
| (click)="setColorTheme('neutral')"> | ||
| <span class="option-dot"></span> | ||
| Neutral | ||
| </button> | ||
| <button | ||
| type="button" | ||
| class="theme-option" | ||
| [class.selected]="colorTheme() === 'calm'" | ||
| (click)="setColorTheme('calm')"> | ||
| <span class="option-dot"></span> | ||
| Calm | ||
| </button> | ||
| <button | ||
| type="button" | ||
| class="theme-option" | ||
| [class.selected]="colorTheme() === 'energy'" | ||
| (click)="setColorTheme('energy')"> | ||
| <span class="option-dot"></span> | ||
| Energy | ||
| </button> | ||
| <button | ||
| type="button" | ||
| class="theme-option" | ||
| [class.selected]="colorTheme() === 'passion'" | ||
| (click)="setColorTheme('passion')"> | ||
| <span class="option-dot"></span> | ||
| Passion | ||
| </button> | ||
|
Comment on lines
+21
to
+52
There was a problem hiding this comment. Menu buttons should have role="menuitem" instead of using implicit button role within a role="menu" container. Additionally, each menu item button should have aria-checked attribute to indicate selected state for better screen reader support, not just a visual class. |
||
| </div> | ||
| </section> | ||
| <section class="theme-section" aria-label="Radius"> | ||
| <h4 class="theme-section-title">Radius</h4> | ||
| <div class="theme-options"> | ||
| <button | ||
| type="button" | ||
| class="theme-option" | ||
| [class.selected]="radiusTheme() === 'none'" | ||
| (click)="setRadiusTheme('none')"> | ||
| None | ||
| </button> | ||
| <button | ||
| type="button" | ||
| class="theme-option" | ||
| [class.selected]="radiusTheme() === 'compact'" | ||
| (click)="setRadiusTheme('compact')"> | ||
| Compact | ||
| </button> | ||
| <button | ||
| type="button" | ||
| class="theme-option" | ||
| [class.selected]="radiusTheme() === 'rounded'" | ||
| (click)="setRadiusTheme('rounded')"> | ||
| Rounded | ||
| </button> | ||
| <button | ||
| type="button" | ||
| class="theme-option" | ||
| [class.selected]="radiusTheme() === 'pill'" | ||
| (click)="setRadiusTheme('pill')"> | ||
| Pill | ||
| </button> | ||
| </div> | ||
| </section> | ||
| <section class="theme-section" aria-label="Base"> | ||
| <h4 class="theme-section-title">Base</h4> | ||
| <p class="theme-section-hint">Base affects dark mode surfaces.</p> | ||
| <div class="theme-options"> | ||
| <button | ||
| type="button" | ||
| class="theme-option" | ||
| [class.selected]="baseTheme() === 'default'" | ||
| (click)="setBaseTheme('default')"> | ||
| Default | ||
| </button> | ||
| <button | ||
| type="button" | ||
| class="theme-option" | ||
| [class.selected]="baseTheme() === 'graphite'" | ||
| (click)="setBaseTheme('graphite')"> | ||
| Graphite | ||
| </button> | ||
| <button | ||
| type="button" | ||
| class="theme-option" | ||
| [class.selected]="baseTheme() === 'midnight'" | ||
| (click)="setBaseTheme('midnight')"> | ||
| Midnight | ||
| </button> | ||
| <button | ||
| type="button" | ||
| class="theme-option" | ||
| [class.selected]="baseTheme() === 'aubergine'" | ||
| (click)="setBaseTheme('aubergine')"> | ||
| Aubergine | ||
| </button> | ||
| </div> | ||
| </section> | ||
| </div> | ||
| } | ||
| <button | ||
| class="theme-toggle-btn" | ||
| (click)="toggleTheme()" | ||
| [attr.aria-label]=" | ||
| isDark() ? 'Switch to light mode' : 'Switch to dark mode' | ||
| " | ||
| type="button"> | ||
|
Comment on lines
+124
to
+130
Collaborator
There was a problem hiding this comment. @TerranceKhumalo-absa could we expose the toggle state with aria-pressed or role="switch" + aria-checked? Right now the icon button only has a label. |
||
| <cps-icon [icon]="isDark() ? 'sun' : 'moon'" [size]="20"> </cps-icon> | ||
| </button> | ||
| </div> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TerranceKhumalo-absa in
projects/composition/src/app/app.component.spec.tscould we import ThemeToggleComponent in the test module? ng test logs app-theme-toggle is not a known element, which masks template errors.