Added restService based overload with CachedSchemaRegistryClient#365
Open
DwivediPrasoon wants to merge 2 commits intoAbsaOSS:masterfrom
Open
Added restService based overload with CachedSchemaRegistryClient#365DwivediPrasoon wants to merge 2 commits intoAbsaOSS:masterfrom
DwivediPrasoon wants to merge 2 commits intoAbsaOSS:masterfrom
Conversation
veenaypatil
reviewed
Sep 17, 2024
Comment on lines
+27
to
31
|
|
||
| def this(restService: RestService, maxSchemaObject: Int) = { | ||
| this(ConfluentRegistryClient.createClient(restService, maxSchemaObject)) | ||
| } | ||
| } |
There was a problem hiding this comment.
- Lets update the files where this class is being used.
- Add Test cases
- Add scaladoc for this in terms of how to use this constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to issue: #364
Basic auth doesn't seem to connect to Schema registry on CC using the basic auth method i.e.
but able to connect when used with restService constructor of
CachedSchemaRegistryClient. This PR aims at giving an option to passRestServiceobject to be able to createCachedSchemaRegistryClientfor it.