-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fixed macro error #837
Fixed macro error #837
Conversation
ARM_SAI_ERROR_FRAME_LENGHT -> ARM_SAI_ERROR_FRAME_LENGTH
ARM_SAI_ERROR_FRAME_LENGHT -> ARM_SAI_ERROR_FRAME_LENGTH
ARM_SAI_ERROR_FRAME_LENGHT -> ARM_SAI_ERROR_FRAME_LENGTH
|
Hi @DavidLin1577, thanks for pointing out this typo. Unfortunately correcting the type is a breaking change to this API. Cheers, |
|
You can define both, with the incorrect one marked as deprecated. |
@JonatanAntoni Got it, thanks for your reply. @ilg-ul Thanks for your suggestion and countermeasure. I meet something likes this in my work,"define both" is a good idea and new idea to me,thanks again. |
|
Yep, using |
@JonatanAntoni My pleasure, I'm glad to do this better, I will squash my PR into a single commit. |
Added (@deprecated) to notice the macro 'ARM_SAI_ERROR_FRAME_LENGHT' had been deprecated, and added macro 'ARM_SAI_ERROR_FRAME_LENGTH' to use.
|
@DavidLin1577, you need to remove that merge commit and rebase/squash all your commits onto master in order to let me merge your changes properly. |
@JonatanAntoni thank you for your advise. I got it, but I meet some troubles on this pr when I try serveral times to rebase/squash my commits , I had to fork a new one, and new PR#849. And I will close this pr when #849 finish, thanks. |
ARM_SAI_ERROR_FRAME_LENGHT -> ARM_SAI_ERROR_FRAME_LENGTH