This repository was archived by the owner on Dec 18, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update core_cm33.h #1254
Open
AlbertHuang-CPU
wants to merge
4
commits into
ARM-software:develop
Choose a base branch
from
AlbertHuang-CPU:patch-2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update core_cm33.h #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct a typo.
Member
|
@AlbertHuang-CPU, thanks for pointing this out. We need to be carefull in renaming struct members. This can easily break exiting user applications which should be avoided as much as possible. |
ghost
approved these changes
Jul 21, 2021
JonatanAntoni
suggested changes
Jul 21, 2021
Member
JonatanAntoni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All touched files needs to receive an update to their header information (i.e. file date and version).
Member
|
@AlbertHuang-CPU, are you going to finish this patch? |
Contributor
Author
|
Hi, what need to do? to update the file date or to resolve conversation in the codes, or? |
Collaborator
|
Yes, please. |
update file header
c9155d1 to
1b35075
Compare
Member
|
Outdated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct a typo.