Fix: Prevent GPU memory leak by ensuring sim destruction on reset #701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thank you for maintaining the awesome robosuite!
What this does
I've experienced a GPU memory leak while running a long session with many resets. I found that
self._destroy_sim()was not being called during reset because my renderer wasmjviewer.With
self._destroy_sim()properly called in each reset regardless of the renderer, I no longer see the GPU memory leak.How it was tested
I monitored
nvidia-smiduring my script before and after the fix.Thanks!