a11y: add proper keyboard activation for share button#4
a11y: add proper keyboard activation for share button#4Aarya-Chaudhari wants to merge 3 commits intoAOSSIE-Org:mainfrom
Conversation
WalkthroughRemoved an extra blank line in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/social-share-button.js
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-21T12:11:14.980Z
Learnt from: kpj2006
Repo: AOSSIE-Org/SocialShareButton PR: 1
File: src/social-share-button.js:10-11
Timestamp: 2025-12-21T12:11:14.980Z
Learning: SSR compatibility is important for public libraries. For files under src/, ensure the SocialShareButton (and related public APIs) render correctly in SSR environments across frameworks. Check for browser-only globals, conditional code paths, correct hydration behavior, and that the library exports behave consistently when used in SSR.
Applied to files:
src/social-share-button.js
|
Thanks for the review! You’re right — native elements already support Enter and Space |
| </svg> | ||
| <span>${this.options.buttonText}</span> | ||
| `; | ||
|
|
There was a problem hiding this comment.
have you changed anything??
or you should close the pr since there is no active change
feat: add Preact wrapper for SocialShareButton
This PR improves accessibility by enabling proper keyboard interaction
for the social share button.
This follows native button behavior and improves usability for
keyboard and assistive-technology users without changing UI or behavior.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.