You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Comment on why this hasn't been merged yet: I currently don't really trust the C1 continuity check as assignments etc are not flattened out. This might imply that we could inadvertently miss discontinuities, but maybe it's all fine as we can assume continuity of the respective terms. Haven't thought about it enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pre-commit run --files python/sdist/amici/import_utils.py python/tests/test_heavisides.pypytest python/tests/test_heavisides.py::test_parse_piecewise_c1_no_heaviside python/tests/test_heavisides.py::test_parse_piecewise_discontinuous_to_heaviside python/tests/test_heavisides.py::test_parse_piecewise_c1_constant_zero -qfixes #2049
https://chatgpt.com/codex/tasks/task_b_685d399bee14832b899b26d9136e2fda