Conversation
Since the remote terminus does not support DMTF DSP0248 command GetPDR, use a file with manully mapped PDRs at the remote terminus in JSON format. Once read and parsed, PDRs are acted upon to create numeric sensors according to their respective numeric sensor PDR. Signed-off-by: Shirish Pargaonkar <Shirish.Pargaonkar@amd.com>
|
This is working code. Created a SP7 branch for review but the exact same code would work for SP8 and will |
ojayanth
left a comment
There was a problem hiding this comment.
:Keep AMD-specific logic in oem/amd, use JSON configs for PDRs, and hook generators during platform init—just like IBM and Ampere do. This ensures clean, maintainable, and upstream-compliant design. you can refer Refer to pldm/docs/pdr_implementation.md to follow genrator pattern
Thanks @ojayanth , will work on the changes. |
|
Also, I think we need this https://gerrit.openbmc.org/c/openbmc/pldm/+/85434 which is still being reviewed. The .json file has only one of the multiple compact numeric sensors that exist on the remote terminus (PMFW), so all those sensors need to be coded in as well in the .json file. |
|
Code is not needed anymore |
Since the remote terminus does not support DMTF DSP0248 command GetPDR, use a file with manully mapped PDRs at the remote terminus in JSON format.
Once read and parsed, PDRs are acted upon to create numeric sensors according to their respective numeric sensor PDR.