feat: make --num-slices and --num-cubes optional for reservations#1093
Closed
jamOne- wants to merge 28 commits intoAI-Hypercomputer:mainfrom
Closed
feat: make --num-slices and --num-cubes optional for reservations#1093jamOne- wants to merge 28 commits intoAI-Hypercomputer:mainfrom
jamOne- wants to merge 28 commits intoAI-Hypercomputer:mainfrom
Conversation
jamOne-
force-pushed
the
optional-num-slices
branch
2 times, most recently
from
9fa6df1 to
953ee62
Compare
jamOne-
force-pushed
the
optional-num-slices
branch
2 times, most recently
from
28bacc9 to
4a3a679
Compare
jamOne-
force-pushed
the
optional-num-slices
branch
from
4a3a679 to
a967251
Compare
jamOne-
commented
Mar 6, 2026
- Apply implementer refactoring for _determine_available_capacity and _set_cluster_topology_defaults. - Ensure _determine_available_capacity does not modify args.num_nodes directly and returns early if not using a reservation. - Centralize slice and node defaulting in _set_cluster_topology_defaults. - Update unit tests in cluster_test.py to match new method signatures and test logic. - Fix missing unittest.mock imports. - Mock _determine_available_capacity where required to accurately test _set_cluster_topology_defaults.
jamOne-
force-pushed
the
optional-num-slices
branch
from
9c91896 to
c8da4b4
Compare
…reservation_capacity
…matting, update goldens
…y; regenerate goldens
…t sizing/reservation
…and handle dry-run gracefully
jamOne-
added
release-features
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes
--num-slices,--num-cubesand--num-nodesoptional when using--reservationcapacity.Issue
b/477114716
Testing
Needs thorough testing.