Conversation
jamOne-
requested review from
FIoannides,
SikaGrr,
scaliby and
stony-tark
as code owners
scaliby
reviewed
Feb 9, 2026
Member
scaliby
left a comment
scaliby
left a comment
There was a problem hiding this comment.
Why? I like quotes to be consistent. Having warnings now seems to be a temporal inconvenience that will profit in the future by having consistent quotes.
Collaborator
Author
|
@scaliby IIUC the quotes will still be consistent even if we disable this check. This is because the pyink will format them consistently. The issue with the current setup is that pyink and pylint are not compatible and we have pylint warnings in our current code-base that is pyink-compliant. |
scaliby
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Gemini:
Resolved the
inconsistent-quoteslinting errors by disabling thecheck-quote-consistencycheck in.pylintrc. This avoids conflicts betweenpylintandpyink(which enforces double quotes) without cluttering the code with extra variables or escaping.Issue
Testing
make verify