PR #3204: Migrate MaxText/train_compile.py to maxtext/trainers/pre_train/train_compile.py#3209
Closed
bvandermoon wants to merge 1 commit intomainfrom
Closed
PR #3204: Migrate MaxText/train_compile.py to maxtext/trainers/pre_train/train_compile.py#3209bvandermoon wants to merge 1 commit intomainfrom
bvandermoon wants to merge 1 commit intomainfrom
Conversation
…ain/train_compile.py Imported from GitHub PR #3204 # Description * Move `MaxText/train_compile.py` to `maxtext/trainers/pre_train/train_compile.py` * Create shim in MaxText/train.py to support old command. Include a deprecation warning * TODO: Add deprecation dates to this and other shims we are adding * Next steps: Update [existing `EXECUTABLE` commands](https://github.com/AI-Hypercomputer/maxtext/blob/main/src/maxtext/configs/tpu/v4/22b.sh#L58) to call new path for train/train_compile. Leaving this off for now to keep PR smaller. The old commands still work for these NOTE: We will fix the ungrouped import lint errors at the end of restructuring. Otherwise we will just be swapping the order of imports repeatedly # Tests Both new and old commands working as expected. New command: ``` python3 -m maxtext.trainers.pre_train.train_compile src/maxtext/configs/base.yml \ compile_topology=v5e-256 \ compile_topology_num_slices=2 \ global_parameter_scale=16 \ per_device_batch_size=4 ``` Old command: ``` python3 -m MaxText.train_compile src/maxtext/configs/base.yml \ compile_topology=v5e-256 \ compile_topology_num_slices=2 \ global_parameter_scale=16 \ per_device_batch_size=4 ``` # Checklist Before submitting this PR, please make sure (put X in square brackets): - [x] I have performed a self-review of my code. For an optional AI review, add the `gemini-review` label. - [x] I have necessary comments in my code, particularly in hard-to-understand areas. - [x] I have run end-to-end tests tests and provided workload links above if applicable. - [x] I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in [our documentation](https://maxtext.readthedocs.io/en/latest/development.html#adding-new-documentation-files). Copybara import of the project: -- 9dc2704 by Branden Vandermoon <bvandermoon@google.com>: Migrate MaxText/train_compile.py to maxtext/trainers/pre_train/train_compile.py Merging this change closes #3204 FUTURE_COPYBARA_INTEGRATE_REVIEW=#3204 from AI-Hypercomputer:bvandermoon-repo-restructure 9dc2704 PiperOrigin-RevId: 873125760
bvandermoon
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
gagika,
gobbleturk,
hengtaoguo,
jacoguzo,
jesselu-google,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
Collaborator
Author
|
This PR was used to diff copybara changes only. These changes were merged in #3204 |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3204: Migrate MaxText/train_compile.py to maxtext/trainers/pre_train/train_compile.py
Imported from GitHub PR #3204
Description
MaxText/train_compile.pytomaxtext/trainers/pre_train/train_compile.pyEXECUTABLEcommands to call new path for train/train_compile. Leaving this off for now to keep PR smaller. The old commands still work for theseNOTE: We will fix the ungrouped import lint errors at the end of restructuring. Otherwise we will just be swapping the order of imports repeatedly
Tests
Both new and old commands working as expected.
New command:
Old command:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.Copybara import of the project:
--
9dc2704 by Branden Vandermoon bvandermoon@google.com:
Migrate MaxText/train_compile.py to maxtext/trainers/pre_train/train_compile.py
Merging this change closes #3204
FUTURE_COPYBARA_INTEGRATE_REVIEW=#3204 from AI-Hypercomputer:bvandermoon-repo-restructure 9dc2704