Open
Conversation
dipannita08
requested review from
A9isha,
Lumosis,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
gpolovets1,
hengtaoguo,
jesselu-google,
jiangjy1982,
jrplatin,
khatwanimohit,
mailvijayasingh,
mitalisi,
parambole,
patemotter,
richjames0,
shralex,
shuningjin,
suexu1025,
vipannalla and
xuefgu
as code owners
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
dipannita08
force-pushed
the
move-maxtext-common
branch
from
cb6530a to
57a93d1
Compare
hengtaoguo
approved these changes
Feb 21, 2026
| from maxtext.common import checkpointing | ||
| from MaxText.common_types import MODEL_MODE_TRAIN | ||
| from maxtext.common.common_types import MODEL_MODE_TRAIN | ||
| from MaxText.globals import MAXTEXT_PKG_DIR |
Collaborator
There was a problem hiding this comment.
Seems the imports are not grouped in this file?
Collaborator
Author
There was a problem hiding this comment.
Yep good catch, thank you! Although we will probably need to do a mass lint fix PR.
bvandermoon
approved these changes
Feb 21, 2026
Comment on lines
24
to
28
| from maxtext.common.common_types import Config | ||
| from maxtext.layers.decoders import DecoderLayer | ||
| from maxtext.layers import multi_token_prediction # The class under test | ||
| from maxtext.layers import embeddings | ||
| from MaxText.common_types import MODEL_MODE_TRAIN | ||
| from maxtext.common.common_types import MODEL_MODE_TRAIN |
Collaborator
There was a problem hiding this comment.
Nit: Not for this PR but the two maxtext.common.common_types imports should be etiher on the same line or grouped together
dipannita08
force-pushed
the
move-maxtext-common
branch
2 times, most recently
from
2108e1e to
34dcb76
Compare
dipannita08
force-pushed
the
move-maxtext-common
branch
from
5591fbb to
93be3f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move maxtext common_types to maxtext/common/.
Tests
Please describe how you tested this change, and include any instructions and/or
commands to reproduce.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.