Conversation
hengtaoguo
force-pushed
the
hengtaoguo-re
branch
from
ac7faa2 to
bc220e5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
hengtaoguo
requested review from
A9isha,
Lumosis,
NicoGrande,
NuojCheng,
Obliviour,
RissyRan,
SujeethJinesh,
SurbhiJainUSC,
bvandermoon,
gagika,
gobbleturk,
gpolovets1,
jiangjy1982,
jrplatin,
khatwanimohit,
mailvijayasingh,
mitalisi,
notabee,
parambole,
patemotter,
richjames0,
shauryagup,
shralex,
shuningjin,
suexu1025 and
vipannalla
as code owners
hengtaoguo
requested review from
aireenmei and
jesselu-google
as code owners
bvandermoon
reviewed
Feb 21, 2026
Collaborator
bvandermoon
left a comment
bvandermoon
left a comment
There was a problem hiding this comment.
Do we need shims to keep supporting the old decode and maxengine commands?
dipannita08
approved these changes
Feb 21, 2026
| from MaxText.common_types import DECODING_ACTIVE_SEQUENCE_INDICATOR, MODEL_MODE_PREFILL | ||
| from maxtext.layers import quantizations | ||
| from MaxText.maxengine import MaxEngine | ||
| from maxtext.inference.maxengine import maxengine |
Collaborator
There was a problem hiding this comment.
Was this extra import intended?
bvandermoon
reviewed
Feb 21, 2026
Comment on lines
-25
to
31
| from MaxText import maxengine | ||
| from MaxText import pyconfig | ||
| from maxtext.common import profiler | ||
| from maxtext.common.gcloud_stub import jetstream, is_decoupled | ||
| from maxtext.inference.maxengine import maxengine | ||
| from maxtext.multimodal import processor as mm_processor | ||
| from maxtext.multimodal import utils as mm_utils | ||
| from maxtext.utils import max_utils |
Collaborator
There was a problem hiding this comment.
This isn't related to your PR, but can this be moved to inference/?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restructure inference-related modules to align with the new
maxtextdirectory. Moved four files and created two__init__.pyas below:src/maxtext/inference/maxengine/:__init___.py.maxengine.pymaxengine_config.pymaxengine_server.pysrc/maxtext/inference/mlperf/microbenchmarks/__init___.pybenchmark_chunked_prefill.pyTests
CI.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.